fix(dag): synthesize final-gate binding and review gate error wording - #306
Merged
Conversation
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #304 and #305 — both discovered by live end-to-end testing of v1.0.21.
#304 — false unresolved_reviews after ACCEPT
workflow(action="status")reportedunresolved_reviewsfor a diff review that settled ACCEPT and completed the graph. Root cause:finalReviewGatesrequires the final gate to map the review's output; the block compiler emitted the follow-upsynthesizewith noinput_mapping, so no gate was ever found and an ACCEPTed review stayed "unresolved" forever. Same contract-vs-binding pattern as the pre-#299 verify gap.Fix: a
synthesizedepending on a review now binds that review's output into itsinput_mapping(its condition is already<review>.output.verdict == "ACCEPT"), satisfying all threefinalReviewGatesaxes. Side effect: block routes shaped… → review → synthesizebecome valid under deep-modevalidateFinalReviewGatetoo, removing the mode cliff.Tests: new compile-seam case asserts the binding exists (and is absent without a review dependency); existing
unresolvedReviewOutcomescases already prove the resolver accepts this shape.#305 — gate message claimed "deep workflow" in all modes
ReviewGateErrorwording dropped the unsupported mode claim (gate behavior unchanged). The wake-integration test now pins the message free of the "deep workflow" wording.Verification
bun typecheckclean.